-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration & MySql Query addCheck() and dropCheck() #19881
Conversation
bobonov
commented
Jul 5, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | #19817, #19819 |
…ng addheck() and dropCheck(), resolve yiisoft#19819
PR Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19881 +/- ##
=============================================
+ Coverage 18.65% 60.49% +41.84%
- Complexity 11379 11383 +4
=============================================
Files 430 430
Lines 37071 37103 +32
=============================================
+ Hits 6915 22445 +15530
+ Misses 30156 14658 -15498 ☔ View full report in Codecov by Sentry. |
hi, @bobonov, would have time to apply the suggestions, to finish the PR, Thks. |
Hi, add line in changelog, Thks, |
@bobonov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to enable MySQL tests for this feature:
public function testAddDropCheck() |
done. |
This PR needs to be updated, since for Yii2 to correctly support |
The PR title and changelog need to be updated too, since it does more than add/drop check |
Thanks everyone and especially @bobonov and @terabytesoftw for your work on the PR |